Date: Fri, 15 Feb 2019 12:54:01 -0700 From: Ian Lepore <ian@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: Enji Cooper <yaneurabeya@gmail.com>, Eric Joyner <erj@freebsd.org>, Robert Huff <roberthuff@rcn.com>, FreeBSD Current <current@freebsd.org> Subject: Re: problem building dev/e1000 Message-ID: <50b76fd19c51acda91ca56d429b5539053ce74a9.camel@freebsd.org> In-Reply-To: <CANCZdfqWBJU_JXtE==cVX-jiseDtbKSc4FjToArnhj7dQ_p68Q@mail.gmail.com> References: <23653.56460.521599.489556@jerusalem.litteratus.org> <754B5C21-656B-4A67-BA39-50BB4AF5C0CD@gmail.com> <CAKdFRZjdR0%2BMEFhApLcV5me8Nt=R7F1yOoW34owQYne-T9Ehmg@mail.gmail.com> <652F1541-52DE-4744-8AEA-8EE6434E04E8@gmail.com> <39629f6cb41cff32b348cf5d329d425352c28464.camel@freebsd.org> <CANCZdfqWBJU_JXtE==cVX-jiseDtbKSc4FjToArnhj7dQ_p68Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 2019-02-15 at 12:32 -0700, Warner Losh wrote: > On Fri, Feb 15, 2019 at 12:17 PM Ian Lepore <ian@freebsd.org> wrote: > > > On Fri, 2019-02-15 at 10:53 -0800, Enji Cooper wrote: > > > > [...] > > > > > > HO Eric! > > > > > > iflib was a recently added requirement on stable/12 IIRC..? > > > > > > Does the manpage note this dependency, and is there an UPDATING > > > entry > > > for this change? > > > > > > Thanks! > > > -Enji > > > > > > > My question would be: why? If some drivers have a new dependency on > > iflib, why isn't that expressed in sys/conf/files and handled > > automatically? > > > > Right now we have > > files:net/iflib.c optional ether pci iflib > > in the files file. This would need to change to > > files:net/iflib.c optional ether pci (em | igb | ...) > > but we don't have a () operator in config. Or we'd need dozens of > lines, > and the duplicate elimination code in config has been tricky (though > I > didn't check it just now). > > Warner > I guess the question would be how many things does '...' represent now and in the future? What it would need to be, given our current inflexible config(8) is net/iflib.c optional ether pci em | ether pci igb | ... So if ... is 2 or 3 more drivers, that's not so bad. If iflib is eventually going to be used by dozens of drivers, even the parens would make for a pretty ugly solution. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50b76fd19c51acda91ca56d429b5539053ce74a9.camel>