Date: Thu, 13 Dec 2007 20:26:44 -0800 From: "Kip Macy" <kip.macy@gmail.com> To: "Julian Elischer" <julian@elischer.org> Cc: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>, src-committers@freebsd.org, Kip Macy <kmacy@freebsd.org>, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/conf files src/sys/netinet tcp_ofld.c tcp_ofld.h tcp_var.h toedev.h src/sys/sys socket.h Message-ID: <b1fa29170712132026g3fb4f246nc038a4a3c4e0408d@mail.gmail.com> In-Reply-To: <4761BB7C.3010907@elischer.org> References: <200712122021.lBCKLdvt045540@repoman.freebsd.org> <20071213223319.E81630@maildrop.int.zabbadoz.net> <4761BB7C.3010907@elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Please review the following change: http://www.fsmware.com/freebsd/tcp/tcp_offload.diff This will replace tcp_ofld.[ch] I'm currently prefixing the dispatch functions that will be added to the actual tcp code with tcp_gen gen == {generic, general}. I'm not attached to the name so if there is a consensus there I will change it. -Kip On Dec 13, 2007 3:08 PM, Julian Elischer <julian@elischer.org> wrote: > Bjoern A. Zeeb wrote: > > On Wed, 12 Dec 2007, Kip Macy wrote: > > > > Hi, > > > >> kmacy 2007-12-12 20:21:39 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/conf files > >> sys/netinet tcp_var.h > >> sys/sys socket.h > >> Added files: > >> sys/netinet tcp_ofld.c tcp_ofld.h toedev.h > >> Log: > >> Add driver independent interface to offload active established TCP > >> connections > >> > >> Reviewed by: silby > >> > >> Revision Changes Path > >> 1.1256 +1 -0 src/sys/conf/files > >> 1.1 +126 -0 src/sys/netinet/tcp_ofld.c (new) > >> 1.1 +198 -0 src/sys/netinet/tcp_ofld.h (new) > > I think I'd have just gone for > tcp_offload.c > it's not the longest filename in the system. > > > > > > I consider that just for the archives .. > > > > .. but is there a reason you abbreviated those file names like that? > > It's not like we live with 8.3 contrainsts. > > > > The first time I parsed it as "of ld", then realiazed it should be > > "off ld" and then wondered why it wasn't just "offload" like it is > > "syncache" or "timewait" or "hostcache"? > > > > And yes, I wondered the same about the functions names, ... > > > > Was that spelling inherited from another implementation/standard/whatever? > > > > > > > >> 1.159 +4 -1 src/sys/netinet/tcp_var.h > >> 1.1 +132 -0 src/sys/netinet/toedev.h (new) > >> 1.96 +2 -0 src/sys/sys/socket.h > >> > > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b1fa29170712132026g3fb4f246nc038a4a3c4e0408d>