Date: Tue, 31 Jul 2007 04:47:34 GMT From: Christopher Davis <loafier@FreeBSD.org> To: Perforce Change Reviews <perforce@FreeBSD.org> Subject: PERFORCE change 124401 for review Message-ID: <200707310447.l6V4lY69064416@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=124401 Change 124401 by loafier@chrisdsoc on 2007/07/31 04:46:39 Minor changes to write macros. Affected files ... .. //depot/projects/soc2007/loafier_busalloc/src/sys/dev/sound/pci/hda/hdac.c#2 edit .. //depot/projects/soc2007/loafier_busalloc/src/sys/dev/sound/pci/hda/hdac_private.h#2 edit Differences ... ==== //depot/projects/soc2007/loafier_busalloc/src/sys/dev/sound/pci/hda/hdac.c#2 (text+ko) ==== @@ -1477,8 +1477,6 @@ "%s: Unable to allocate memory resource\n", __func__); return (ENOMEM); } - mem->mem_tag = rman_get_bustag(mem->mem_res); - mem->mem_handle = rman_get_bushandle(mem->mem_res); return (0); } ==== //depot/projects/soc2007/loafier_busalloc/src/sys/dev/sound/pci/hda/hdac_private.h#2 (text+ko) ==== @@ -42,17 +42,17 @@ * Helper Macros ****************************************************************************/ #define HDAC_READ_1(mem, offset) \ - bus_space_read_1((mem)->mem_tag, (mem)->mem_handle, (offset)) + bus_read_1((mem)->mem_res, (offset)) #define HDAC_READ_2(mem, offset) \ - bus_space_read_2((mem)->mem_tag, (mem)->mem_handle, (offset)) + bus_read_2((mem)->mem_res, (offset)) #define HDAC_READ_4(mem, offset) \ - bus_space_read_4((mem)->mem_tag, (mem)->mem_handle, (offset)) + bus_read_4((mem)->mem_res, (offset)) #define HDAC_WRITE_1(mem, offset, value) \ - bus_space_write_1((mem)->mem_tag, (mem)->mem_handle, (offset), (value)) + bus_write_1((mem)->mem_res, (offset), (value)) #define HDAC_WRITE_2(mem, offset, value) \ - bus_space_write_2((mem)->mem_tag, (mem)->mem_handle, (offset), (value)) + bus_write_2((mem)->mem_res, (offset), (value)) #define HDAC_WRITE_4(mem, offset, value) \ - bus_space_write_4((mem)->mem_tag, (mem)->mem_handle, (offset), (value)) + bus_write_4((mem)->mem_res, (offset), (value)) #define HDAC_ISDCTL(sc, n) (_HDAC_ISDCTL((n), (sc)->num_iss, (sc)->num_oss)) #define HDAC_ISDSTS(sc, n) (_HDAC_ISDSTS((n), (sc)->num_iss, (sc)->num_oss)) @@ -97,8 +97,6 @@ struct hdac_mem { struct resource *mem_res; int mem_rid; - bus_space_tag_t mem_tag; - bus_space_handle_t mem_handle; }; /****************************************************************************
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200707310447.l6V4lY69064416>