Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 6 Feb 2005 13:35:40 +0100 (CET)
From:      mw@kpnqwest.ch
To:        freebsd-current@freebsd.org
Subject:   Re: logitec usb wireless mouse
Message-ID:  <200502061235.j16CZemN039988@smsgw.vianetworks.ch>
In-Reply-To: <20050206120657.GB22743@dragon.nuxi.com>

next in thread | previous in thread | raw e-mail | index | archive | help
> > +       bzero (&h, sizeof (h));
> >         for (d = hid_start_parse(buf, len, 1<<k); hid_get_item(d, &h); )
> > -               if (h.report_ID != 0)
> > +               if (h.report_ID != 0 && !id)
> 
> Is the real magic the "&& !id"?  My read of the code doesn't see the need
> for the bzero as hid_get_item should be filling 'h'.

Yup, I'm just the paranoid type of person who likes to have properly
(as opposed to magically;-)) initialized structures.

Markus



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200502061235.j16CZemN039988>