Date: Thu, 18 Aug 2011 10:31:50 +0800 From: Adrian Chadd <adrian@freebsd.org> To: PseudoCylon <moonlightakkiy@yahoo.ca> Cc: freebsd-wireless@freebsd.org Subject: Re: ieee80211_process_callback() use in drivers Message-ID: <CAJ-Vmonw=4K4wNo64zU5UDgWkp4zc9P2v90sY1F1ZYWDfaCTsg@mail.gmail.com> In-Reply-To: <CAFZ_MYLPnH=wMF1uiLCV08LnQztPBA-OkQ8zVKSvp7ZHm%2BvJ1Q@mail.gmail.com> References: <CAFZ_MYJGv8zhJLaAjs_o2mxjjopYofSoymgwfMnO-79nKub66w@mail.gmail.com> <CAJ-VmomS%2Bo%2BvJTjCC26FoXHf6JESDofLgZH4vZRSRKNM3ZgVkQ@mail.gmail.com> <CAFZ_MYLPnH=wMF1uiLCV08LnQztPBA-OkQ8zVKSvp7ZHm%2BvJ1Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 18 August 2011 10:10, PseudoCylon <moonlightakkiy@yahoo.ca> wrote: >> Hm, I fixed the status check in the BAR TX routines. >> Is that enough? Or are you saying that the node ref is freed somewhere >> inside ic_raw_xmit() on a TX failure? > > Sorry, I found the commit after replied. > > But, drivers call ieee80211_free_node() in ic_raw_xmit() on failure. Hm, so we can't kill the free, because ieee80211_ref_node() is called early on. So if ic->ic_raw_xmit(), just return ret, rather then "goto bad" ? Adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmonw=4K4wNo64zU5UDgWkp4zc9P2v90sY1F1ZYWDfaCTsg>