Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 15 Aug 2016 16:03:50 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-net@FreeBSD.org
Subject:   [Bug 211836] Kernel panic with net.isr enabled
Message-ID:  <bug-211836-2472-rMErqsevdB@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-211836-2472@https.bugs.freebsd.org/bugzilla/>
References:  <bug-211836-2472@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211836

--- Comment #10 from Andrey V. Elsukov <ae@FreeBSD.org> ---
(In reply to Babak Farrokhi from comment #9)
> Created attachment 173703 [details]
> textdump after applying patch from @ae
>=20
> Panicked again after patch

Ok, this is yet another case :)
Can you test this patch instead? It should cover both (all) cases.
The NETISR_DISPATCH_HYBRID case looks not quite correct, but it is better t=
han
panic...

Index: sys/net/netisr.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- sys/net/netisr.c    (revision 304101)
+++ sys/net/netisr.c    (working copy)
@@ -810,10 +810,12 @@ netisr_select_cpuid(struct netisr_proto *npp, u_in
                 * dispatch.  In the queued case, fall back on the SOURCE
                 * policy.
                 */
-               if (*cpuidp !=3D NETISR_CPUID_NONE)
+               if (*cpuidp !=3D NETISR_CPUID_NONE) {
+                       *cpuidp =3D nws_array[ *cpuidp % nws_count ];
                        return (m);
+               }
                if (dispatch_policy =3D=3D NETISR_DISPATCH_HYBRID) {
-                       *cpuidp =3D curcpu;
+                       *cpuidp =3D nws_array[ curcpu % nws_count ];
                        return (m);
                }
                policy =3D NETISR_POLICY_SOURCE;

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-211836-2472-rMErqsevdB>