Date: Sun, 4 Apr 2004 20:55:30 -0700 (PDT) From: Nate Lawson <nate@root.org> To: Jeff Roberson <jeff@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern sched_ule.c Message-ID: <20040404205507.T17609@root.org> In-Reply-To: <20040404191311.44B1916A4E9@hub.freebsd.org> References: <20040404191311.44B1916A4E9@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 4 Apr 2004, Jeff Roberson wrote:
> Modified files:
> sys/kern sched_ule.c
> Log:
> - Use the proper constant in sched_interact_update(). Previously,
> SCHED_INTERACT_MAX was used where SCHED_SLP_RUN_MAX was needed. This was
> causing the interactivity scaler to lose history at a more dramatic rate
> than intended.
>
> Revision Changes Path
> 1.103 +1 -1 src/sys/kern/sched_ule.c
>
>
> --- src/sys/kern/sched_ule.c:1.102 Sat Mar 27 10:21:24 2004
> +++ src/sys/kern/sched_ule.c Sun Apr 4 12:12:56 2004
> @@ -1043,7 +1043,7 @@
> * will not bring us back into range. Dividing by two here forces
> * us into the range of [3/5 * SCHED_INTERACT_MAX, SCHED_INTERACT_MAX]
> */
> - if (sum > (SCHED_INTERACT_MAX / 5) * 6) {
> + if (sum > (SCHED_SLP_RUN_MAX / 5) * 6) {
> kg->kg_runtime /= 2;
> kg->kg_slptime /= 2;
> return;
It seems the comment is now out of synch.
-Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040404205507.T17609>