Date: Tue, 20 Aug 2002 04:40:19 +0900 From: Hajimu UMEMOTO <ume@mahoroba.org> To: Juli Mallett <jmallett@FreeBSD.org> Cc: net@FreeBSD.org Subject: Re: log_in_vain does not format IPv6 addrs properly for how they are used... Message-ID: <ygen0ri7i3g.wl@mille.mahoroba.org> In-Reply-To: <20020819115048.A47313@FreeBSD.org> References: <20020819112408.A45895@FreeBSD.org> <ygeofby7kt6.wl@mille.mahoroba.org>
index | next in thread | previous in thread | raw e-mail
Hi,
>>>>> On Mon, 19 Aug 2002 11:50:49 -0700
>>>>> Juli Mallett <jmallett@FreeBSD.org> said:
jmallett> Yeah, but it's still tough for readability, all those [0-9A-F:]+
Yes, actually.
jmallett> Okay, thanks. What about with a change to netinet6/udp6_usrreq.c to simply
jmallett> log() with brackets, like:
jmallett> - "Connection attempt to UDP %s:%d from %s:%d\n",
jmallett> + "Connection attempt to UDP [%s]:%d from [%s]:%d\n",
jmallett> If that's an OK change to make, too, then I will commit these changes.
Though netinet6/udp6_usrreq.c is in common part of KAME repo., here is
still FreeBSD specific part, and enclosed by #ifdef __FreeBSD__ ... #endif
in KAME repo. So, please go ahead.
Sincerely,
--
Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan
ume@mahoroba.org ume@bisd.hitachi.co.jp ume@{,jp.}FreeBSD.org
http://www.imasy.org/~ume/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ygen0ri7i3g.wl>