Date: Thu, 26 Feb 2009 21:33:48 +0000 (UTC) From: Alexander Motin <mav@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/dev/ata ata-all.c ata-all.h ata-queue.c ata-raid.c Message-ID: <200902262134.n1QLY2xd054216@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
mav 2009-02-26 21:33:48 UTC
FreeBSD src repository
Modified files:
sys/dev/ata ata-all.c ata-all.h ata-queue.c
ata-raid.c
Log:
SVN rev 189091 on 2009-02-26 21:33:48Z by mav
Remove direct ata_completed() call options from ata_finish(), except for the
kernel dumping case.
ata_completed() may initiate ata_reinit() on error, that may lead to drives
attach or detach. Attach and detach are sending requests to drives and sleep
waiting for results. But ata_finish() can be called directly from
interrupt handler where sleeping is prohibited, so we must break this chain
somewhere. This place seems to fit best.
Revision Changes Path
1.300 +1 -1 src/sys/dev/ata/ata-all.c
1.140 +0 -1 src/sys/dev/ata/ata-all.h
1.80 +1 -7 src/sys/dev/ata/ata-queue.c
1.132 +8 -8 src/sys/dev/ata/ata-raid.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200902262134.n1QLY2xd054216>