Date: Thu, 9 Oct 2003 13:22:13 -0700 From: Hiten Pandya <hmp@nxad.com> To: "Jacques A. Vidrine" <nectar@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libufs bread.3 cgread.3 getino.3 libufs.3 sbread.3 ufs_disk_close.3 Message-ID: <20031009202213.GA76157@perrin.nxad.com> In-Reply-To: <20031009121355.GD94235@madman.celabo.org> References: <200310090945.h999jKns055269@repoman.freebsd.org> <20031009121355.GD94235@madman.celabo.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Oct 09, 2003 at 07:13:55AM -0500, Jacques A. Vidrine wrote: : I think you removed the wrong header. Is <sys/param.h> required in : each of these cases? If not, then I believe the synopsis should refer : only to <sys/types.h>: : : (1) Including <sys/types.h> is (by definition) less work than : <sys/param.h>. I remove the most logical one and also, there was some discussion about it on IRC. Also, I was doing an mdoc review of all the lib manual pages, and I thought I would fix this, but I did not do a deep code review to see which header fits best for libufs, as I did not see a reason for it. : (2) <sys/types.h> is a POSIX header, while <sys/param.h> is not. LibUFS is not a POSIX library anyway, so I don't see what this has got to do with anything. If anyone is inclined on me backing this out, I don't mind, although, I made a judgement/logical call when committing this. Regards, -- Hiten Pandya hmp@FreeBSD.ORG, hmp@backplane.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031009202213.GA76157>