Date: Sun, 14 Jul 1996 10:58:42 -0700 From: Jason Thorpe <thorpej@nas.nasa.gov> To: Paul Traina <pst@shockwave.com> Cc: Wolfram Schneider <wosch@cs.tu-berlin.de>, Nate Williams <nate@freefall.freebsd.org>, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-usrbin@freefall.freebsd.org Subject: Re: cvs commit: src/usr.bin/rdist defs.h docmd.c expand.c lookup.c server.c Message-ID: <199607141758.KAA29768@lestat.nas.nasa.gov>
next in thread | raw e-mail | index | archive | help
On Sun, 14 Jul 1996 10:22:32 -0700 Paul Traina <pst@shockwave.com> wrote: > That's way over-board. The only case where sprintf can get you into trouble > is if you're sprintfing tainted variables (to steal a perl term) into a stack > buffer. It may be overboard, but it certainly doesn't _hurt_ :-) > Should we disable sprintf() for sgid/suid programs? > > find /bin /usr/bin /sbin /usr/sbin /usr/libexec -perm -u+s \ > -o -perm -g+s |xargs egrep -l sprintf | wc -l > > 47 Not that many, and it's probably worth it. We're thinking of doing that in the NetBSD camp, too. I'd say that for the relatively small amount of work that it would take to sweep-up, the quality added to one's sleep makes the choice clear :-) -- save the ancient forests - http://www.bayarea.net/~thorpej/forest/ -- Jason R. Thorpe thorpej@nas.nasa.gov NASA Ames Research Center Home: 408.866.1912 NAS: M/S 258-6 Work: 415.604.0935 Moffett Field, CA 94035 Pager: 415.428.6939
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199607141758.KAA29768>