Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 13 Sep 2007 19:52:15 GMT
From:      "Constantine A. Murenin" <cnst@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 126374 for review
Message-ID:  <200709131952.l8DJqF7S049309@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=126374

Change 126374 by cnst@dale on 2007/09/13 19:51:24

	the invalid flag usually means all fields are invalid,
	not just the value field

Affected files ...

.. //depot/projects/soc2007/cnst-sensors/sbin.sysctl/sysctl.c#10 edit

Differences ...

==== //depot/projects/soc2007/cnst-sensors/sbin.sysctl/sysctl.c#10 (text+ko) ====

@@ -418,14 +418,17 @@
 		return (1);
 	}
 
-	if (s->flags & SENSOR_FINVALID)
+	if (s->flags & SENSOR_FINVALID) {
 		/*
 		 * XXX: with this flag, the node should be entirely ignored,
 		 * but as the magic-based sysctl(8) is not too flexible, we
 		 * simply have to print out that the sensor is invalid.
 		 */
 		printf("invalid");
-	else if (s->flags & SENSOR_FUNKNOWN)
+		return (0);
+	}
+
+	if (s->flags & SENSOR_FUNKNOWN)
 		printf("unknown");
 	else {
 		switch (s->type) {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200709131952.l8DJqF7S049309>