Date: Mon, 14 Feb 2005 18:08:38 +0200 From: Alexey Zelkin <phantom@FreeBSD.org.ua> To: Hajimu UMEMOTO <ume@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/include netdb.h src/lib/libc/net getaddrinfo.c Message-ID: <20050214160838.GA1414@phantom.cris.net> In-Reply-To: <ygeu0of5e4z.wl%ume@mahoroba.org> References: <200502141133.j1EBXC6D001449@repoman.freebsd.org> <ygeu0of5e4z.wl%ume@mahoroba.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Feb 15, 2005 at 12:56:28AM +0900, Hajimu UMEMOTO wrote: > Hi, > > >>>>> On Mon, 14 Feb 2005 11:33:12 +0000 (UTC) > >>>>> Alexey Zelkin <phantom@FreeBSD.org> said: > > phantom> . Convert ai_errlist[] to simple 'char *' array, and appropriately > phantom> optimize gai_strerror() > > Why did you do this? Since this departs from KAME's getaddrinfo.c, I > don't want this change unless there is meaningful advantage. 1. This is optimization. 2. This is preparation to addition of NLS support for gai_strerror() Actually, since gai_strerror() is exported function and only user of ai_errlist[], would not it be better to move these to separate source file ? It will make KAME integration for getaddrinfo.c much easier, IMHO. -- /* Alexey Zelkin && Independent Contractor */ /* phantom(at)FreeBSD.org && http://www.FreeBSD.org/java */ /* phantom(at)cris.net && http://www.FreeBSD.org.ua/ */
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050214160838.GA1414>