Date: Tue, 28 Jun 2016 18:22:39 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Hans Petter Selasky <hps@selasky.org> Cc: Slawa Olhovchenkov <slw@zxy.spb.ru>, ports@FreeBSD.org, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: pkg SAT_SOLVER bugs Message-ID: <20160628162239.nopc2r2mtleuszpm@ivaldir.etoilebsd.net> In-Reply-To: <0671148b-d7cd-f8ad-906d-a0baa1b98cf5@selasky.org> References: <20150414200459.GE39658@ivaldir.etoilebsd.net> <20150421103454.GR1394@zxy.spb.ru> <5593D0AE.2010205@selasky.org> <416359ce-1dcd-1160-5c56-f120a0f6358f@selasky.org> <20160627115533.gqvdsmtzwnvrrfuo@ivaldir.etoilebsd.net> <0671148b-d7cd-f8ad-906d-a0baa1b98cf5@selasky.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Tue, Jun 28, 2016 at 05:52:32PM +0200, Hans Petter Selasky wrote: > On 06/27/16 13:55, Baptiste Daroussin wrote: > > On Mon, Jun 27, 2016 at 12:38:02PM +0200, Hans Petter Selasky wrote: > > > Hi, > > > > > > I found some bugs in PKG with regard to the SAT_SOLVER environment variable. > > > Please find patch attached :-) > > > > > > Issues fixed: > > > 1) No need to use hash table when generating SAT rules for external solver. > > > Variables are already in a linear array. Fix encoding and decoding of SAT > > > data. > > > 2) Endless variable loop caused pkg to crash. > > > 3) it->inverse was checked for non-zero, while it should actually be checked > > > for -1 only. SAT rules produces were all negative. > > > > > > How to verify: > > > > > > make -C /usr/ports/math/picosat all install clean > > > > > > env SAT_SOLVER=picosat pkg upgrade > > > > > > --HPS > > > > Thank you I will look into shortly > > > > Hi Baptiste, > > Are you handling this one or do you want me to create an issue at github. > Thank you! > I am handling it BTW not that picosat is the one we use internally already :D Best regards Bapt [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXcqRPAAoJEGOJi9zxtz5acagQAKZqpdQ5XLmufX2lCsWndnRv WM0aySvnlXJ0+FEmCIHMZBF1xnIupOQA5ZaBFFMcUXFruCuNykEpgSdKVxBP1SA7 VwBoFlQCDolHsA4ItNidGn8SioPdUG+M0ufqEvgOd7vVkT+QJajlYeccBp0Rss3J LQY7t7eBji9jRcHcrMvdXgY28DdPntu72qxypiMc3Vfc5EycR93Nm4ImoKWZMbk/ X+5ph5zM3xM/NwImTOZO13nZfjhmKRR5GGlcgC6QR1c6enaE9ua8LRA4/hbLsyqX 0dVgRXYwmy51+GzNewAQU2Et+9EOCz8CWxcXEk6dgxl6C89YYhrhelEK/or+be0Z NcMgAki5BZfluVekMuOGEzdqm6UMIbq2lsMQBN2HwwUQjMmBMHUcP0J5ahQOOkEp brXalOiTBQwctUqxRXSA4ob+vbALcn8z08TLtq2WjDYnl1E0s3hoHe+PfHgLTbHE e6mj54Nt5KXqMogZKAjT6K6xkDT56vQNndP1RXnfS7wS+7t6K2zZs/k7nzekcjKk b3D27UtxPo4uqsDo4q717GFr84bzgt6uBq1Uz1ZN+Daahw/6MO16TD6M4ZHgIsaT y+nIu7MRsHRI6/n5G56eI72Rk4YCq2Mp2tZeV14qoMWK5Ro54DjLEQeceZIPQK1C cC1VeVVbAaXbFgpwLJO3 =5/Q9 -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160628162239.nopc2r2mtleuszpm>