Date: Sat, 27 Jun 2020 09:32:02 -0600 From: Warner Losh <imp@bsdimp.com> To: Michael Gmelin <freebsd@grem.de> Cc: John Baldwin <jhb@freebsd.org>, Andriy Gapon <avg@freebsd.org>, Li-Wen Hsu <lwhsu@freebsd.org>, "Conrad E. Meyer" <cem@freebsd.org>, FreeBSD CURRENT <freebsd-current@freebsd.org> Subject: Re: weird Ctrl-T debug messages Message-ID: <CANCZdfpkxOL2aiTTJsdmJdmpbz%2Bq4aKECNRiH%2B6zKYdBzxN_bg@mail.gmail.com> In-Reply-To: <20200627164959.15752fb2@bsd64.grem.de> References: <20200627090406.68b5d637@hermann.fritz.box> <CAKBkRUx-TTWUxPJGiiyMxVFFK=v2is5Rc4QruiNgchWf_WY7Dg@mail.gmail.com> <14d1708f-74cc-4a60-3282-3308eb24743e@FreeBSD.org> <20200627115910.4fe32aa6@bsd64.grem.de> <61989d05-324a-0b8d-d0cf-0da5f3d9f00d@FreeBSD.org> <20200627164959.15752fb2@bsd64.grem.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jun 27, 2020 at 8:50 AM Michael Gmelin <freebsd@grem.de> wrote: > > > On Sat, 27 Jun 2020 06:21:17 -0700 > John Baldwin <jhb@FreeBSD.org> wrote: > > > On 6/27/20 2:59 AM, Michael Gmelin wrote: > > > > > > > > > On Sat, 27 Jun 2020 12:06:17 +0300 > > > Andriy Gapon <avg@FreeBSD.org> wrote: > > > > > >> On 27/06/2020 10:44, Li-Wen Hsu wrote: > > >>> On Sat, Jun 27, 2020 at 3:04 PM Hartmann, O. > > >>> <ohartmann@walstatt.org> wrote: > > >>>> > > >>>> Running poudriere on recent CURRENT with (recent) 12-STABLE and > > >>>> CURRENT jails reveals a weird behaviour recently when hitting > > >>>> Ctrl-T: > > >>> ... > > >>>> Is this debug fallout from /bin/sh? > > >>> > > >>> It's because kern.tty_info_kstacks is on by default now: > > >>> > > >>> https://svnweb.freebsd.org/changeset/base/362141 > > >> > > >> May I suggest that the stack trace is printed procstat -kk style > > >> (single line) ? I think that the more compact output would be more > > >> convenient. > > > > > > It's a cool feature and having it on by default on CURRENT certainly > > > helps to discover it, which is great. Thanks for implementing this! > > > > > > I wouldn't enable it by default on RELEASE versions though, as > > > CTRL-T is a user interface to get status information (at least this > > > is how I use it personally, e.g., while running commands like > > > dd[0], cp, mv, poudriere etc.), not for getting debug output. > > > > I agree with this. > > > > > Question: Speaking of discovering the feature, wouldn't it make > > > sense to document this tunable on the stack(9) and/or tty(4) man > > > page(s)? > > > > This sounds like a great idea. Would you able to come up with a > > patch? I'd be happy to review it. > > Sure, it actually seems like that termios(4) is the best > place to put this information. > > https://reviews.freebsd.org/D25488 Damn, when I read this, I thought it was patches to control this on a per-tty basis by putting it in termios... That would be even cooler :) Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpkxOL2aiTTJsdmJdmpbz%2Bq4aKECNRiH%2B6zKYdBzxN_bg>