Date: Tue, 25 Jul 2017 10:25:29 -0700 From: John Baldwin <jhb@freebsd.org> To: Kristof Provost <kp@freebsd.org> Cc: Ngie Cooper <yaneurabeya@gmail.com>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r321370 - head/lib/libsysdecode Message-ID: <2783492.qOfDobczBC@ralph.baldwin.cx> In-Reply-To: <8FA5355F-E374-49BE-B2B2-25351ED827A9@FreeBSD.org> References: <201707221251.v6MCpKn4014224@repo.freebsd.org> <F8B9F48F-0CFC-480D-8CAF-4891A9A2D907@gmail.com> <8FA5355F-E374-49BE-B2B2-25351ED827A9@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday, July 23, 2017 06:03:48 PM Kristof Provost wrote: > On 22 Jul 2017, at 17:42, Ngie Cooper (yaneurabeya) wrote: > > > On Jul 22, 2017, at 5:51 AM, Kristof Provost <kp@FreeBSD.org> wro= te: > >> > >> Author: kp > >> Date: Sat Jul 22 12:51:19 2017 > >> New Revision: 321370 > >> URL: https://svnweb.freebsd.org/changeset/base/321370 > >> > >> Log: > >> Handle WITH/WITHOUT_PF in libsysdecode > >> > >> Only filter out the PF ioctls if we're building without pf suppor= t. > >> Until now those were always filtered out, so truss did not show=20= > >> symbolic > >> names for pf ioctls. > > > > > > Hi Kristof! > > =09'MFC after:=091 week=E2=80=9D should have probably be added to t= his commit. > > =09This change should be MFCed to ^/stable/11 and probably ^/stable= /10=20 > > (in usr.sbin/kdump on 10:=20 > > https://svnweb.freebsd.org/base/stable/10/usr.bin/kdump/mkioctls?re= vision=3D291815&view=3Dmarkup#l25=20 > > <https://svnweb.freebsd.org/base/stable/10/usr.bin/kdump/mkioctls?r= evision=3D291815&view=3Dmarkup#l25>). >=20 > To be honest I wasn=E2=80=99t planning on MFCing this, because it=E2=80= =99s not a=20 > terribly important issue. > That said, if it=E2=80=99d be useful to you (or anyone else) I=E2=80=99= m certainly=20 > willing to do so. >=20 > I=E2=80=99m not sure how much the code changed between 10 and 11, but= MFC to=20 > 11 should be easy, and if the changes are not too extensive I can do = the=20 > merge to 10 as well. libsysdecode is not present in 10. In 10 you'd have to patch the kdump= mkioctls script and the truss and kdump Makefile's. I think it's proba= bly not worth the trouble to MFC to 10. 11 should probably merge fine, tho= ugh you'll have to tweak it since the previous change to remove the disk ha= ck can't be MFC'.d :( Your original version of the patch would be fine fo= r 11 though. --=20 John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2783492.qOfDobczBC>