Date: Mon, 29 Jun 2020 13:47:28 -0400 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: Kyle Evans <kevans@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org>, Edward Tomasz Napiera??a <trasz@freebsd.org> Subject: Re: svn commit: r362769 - in head/sys: amd64/linux amd64/linux32 arm64/linux compat/linux i386/linux Message-ID: <20200629174728.ln77pjbg65v3kxwf@mutt-hbsd> In-Reply-To: <CACNAnaFfdiaQHYvaHb_4XR-RkwXrznNJLYa8vKuenzT_7Ox96A@mail.gmail.com> References: <202006290309.05T39ETZ044859@repo.freebsd.org> <20200629152717.2ojwnipxkmjaoix2@mutt-hbsd> <CACNAnaFfdiaQHYvaHb_4XR-RkwXrznNJLYa8vKuenzT_7Ox96A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--2b2d3wgxtc4uresf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 29, 2020 at 12:42:49PM -0500, Kyle Evans wrote: > On Mon, Jun 29, 2020 at 10:27 AM Shawn Webb <shawn.webb@hardenedbsd.org> = wrote: > > > > Hey Kyle, > > > > On Mon, Jun 29, 2020 at 03:09:14AM +0000, Kyle Evans wrote: > > > Author: kevans > > > Date: Mon Jun 29 03:09:14 2020 > > > New Revision: 362769 > > > URL: https://svnweb.freebsd.org/changeset/base/362769 > > > > > > Log: > > > linuxolator: implement memfd_create syscall > > > > > > This effectively mirrors our libc implementation, but with minor fu= dging -- > > > name needs to be copied in from userspace, so we just copy it strai= ght into > > > stack-allocated memfd_name into the correct position rather than al= locating > > > memory that needs to be cleaned up. > > > > > > The sealing-related fcntl(2) commands, F_GET_SEALS and F_ADD_SEALS,= have > > > also been implemented now that we support them. > > > > > > Note that this implementation is still not quite at feature parity = w.r.t. > > > the actual Linux version; some caveats, from my foggy memory: > > > > > > - Need to implement SHM_GROW_ON_WRITE, default for memfd (in progre= ss) > > > - LTP wants the memfd name exposed to fdescfs > > > - Linux allows open() of an fdescfs fd with O_TRUNC to truncate aft= er dup. > > > (?) > > > > > > Interested parties can install and run LTP from ports (devel/linux-= ltp) to > > > confirm any fixes. > > > > > > PR: 240874 > > > Reviewed by: kib, trasz > > > Differential Revision: https://reviews.freebsd.org/D21845 > > > > RELNOTES? > > > > > > > > Modified: > > > head/sys/amd64/linux/linux_dummy.c > > > head/sys/amd64/linux32/linux32_dummy.c > > > head/sys/arm64/linux/linux_dummy.c > > > head/sys/compat/linux/linux.c > > > head/sys/compat/linux/linux.h > > > head/sys/compat/linux/linux_file.c > > > head/sys/compat/linux/linux_file.h > > > head/sys/i386/linux/linux_dummy.c > > > > Should __FreeBSD_version be bumped? > > >=20 > I'm roping in trasz@, because I'm unsure on either of these points -- > I haven't paid attention and don't know if we typically include linux > syscalls that we implement in relnotes, and given that this commit > only really affects pre-compiled Linux binaries I'm not sure if > there's any utility in bumping __FreeBSD_version; presumably ports > folks can't do anything differently here, and binaries will work just > the same. Hey Kyle, I assumed as much, but I wasn't entirely sure. I thought I'd just ask anyways. Thanks for the clarification. :) --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD GPG Key ID: 0xFF2E67A277F8E1FA GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9 3633 C85B 0AF8 AB23 0FB2 https://git-01.md.hardenedbsd.org/HardenedBSD/pubkeys/src/branch/master/Sha= wn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --2b2d3wgxtc4uresf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAl76KSsACgkQ/y5nonf4 4foVHw/+M7P2PtbrYgTpYcuieXRoHk0M3V8OUFP9v5l/Eof94f+sSvBQqzF5279j 045OkhvaXNeCKpXUxOAy/D0HXQQWNMB4JenMAQHkVEJ/fAnnXmFdtMgzUjEZHPB2 Ka3SyByuwCBarZFQymDpquLFsU8N6IG+yHYPmedXhQnYBchAlHr7oMUfoDLiwF8X SCJCASu5hrKwv1XMWa7HB9xTAmUiG4Qo2Lc8PAQaNVcIWQJJraDJIoI7PylfDi1M mMoVulM90P8GbpkiuxASr9459O5kCk0cVmfvZrtCC0Mc8PwnuF6WLBiSIP9rJMAz I8gDhXTCU62Ds88r7B0JXE+5DzZvTyDKdLDgqTc3+EtzAbIDzy+Tu818XfnBMvAI PrjuTvOdeZBbX09yT+ECKZYlwvJZDdQ5jT2fZbQUH+lVaw66dPNwJrjHJ8IRc9mr IW/ZwFTnqqBSNeOBx2ll/YxEnmG193RuZ9Ikv+d/Ku5LYW7uMOI1vorWnOo+HqFz RUflmxi4N2Iuswq7IRmif9/U4p7L43PjZsPIGguSOop+V6XSj2FaomEDgtV/PoJw 4rJVQRTnYsgmbw3EfkgOMp9ir+jrLwcdnxVRKEbpMokwhL4dpo9Uo6d5V2hyoqHb EiyS7mmQDibV1d87MHxmZPyuTS4+aCKHZ2q+hYg4WU2uVc0XD1U= =dOHS -----END PGP SIGNATURE----- --2b2d3wgxtc4uresf--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200629174728.ln77pjbg65v3kxwf>