Date: Tue, 25 Jun 2024 09:15:59 -0400 From: Justin Hibbits <jhibbits@FreeBSD.org> To: Warner Losh <imp@bsdimp.com> Cc: Gleb Smirnoff <glebius@freebsd.org>, Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: c2e9c5bbf022 - main - tpm: Refactor TIS and add a SPI attachment Message-ID: <20240625091559.2f258d3b@ralga.knownspace> In-Reply-To: <CANCZdfqrX9FtdDmZScWn6MNwwD0WRxjzJo9Z93Wcn5qM_rLfug@mail.gmail.com> References: <202405032032.443KWhf0045034@gitrepo.freebsd.org> <ZnnMBXi2sGdtc_67@cell.glebi.us> <20240624161128.33c0f518@ralga.knownspace> <ZnniHBI7bg--g8pV@cell.glebi.us> <CANCZdfqrX9FtdDmZScWn6MNwwD0WRxjzJo9Z93Wcn5qM_rLfug@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 24 Jun 2024 16:07:56 -0600 Warner Losh <imp@bsdimp.com> wrote: > On Mon, Jun 24, 2024, 3:16=E2=80=AFPM Gleb Smirnoff <glebius@freebsd.org> > wrote: >=20 > > On Mon, Jun 24, 2024 at 04:11:28PM -0400, Justin Hibbits wrote: =20 > > J> > sorry for late notice, but we just discovered that after this > > J> > commit tpm(4) on ACPI no longer attaches. From what I see > > J> > ther probe method isn't even called. =20 > > J> > > J> Hi Gleb, > > J> > > J> That's very odd. The probe method hasn't changed, nor has the > > J> tpm_acpi attachment (still acpi), so I'm really confused why it > > J> wouldn't be called now. Is there any debugging you can do to > > J> further narrow it down? I haven't seen any issues reported > > J> internally at Juniper on x86 hardware. I just verified > > J> everything should get built properly. =20 > > > > I started adding printfs to the probe method and as said - it is not > > even called. So I puzzled on where to start the debugging. I can > > test patches/ideas if you have any. > > > > Warner is also looking into this problem. > > =20 >=20 > I'm looking at name mismatched and/or moved parents to see if that's > in play. I thought I'd found something like this earlier, but it was > a false alarm I think. >=20 > Warner >=20 > > =20 I just saw bbecd3148abf. Sorry for the breakage, thanks for fixing it! - Justin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20240625091559.2f258d3b>