Date: Sat, 16 Nov 2019 03:53:19 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 234793] Failed unknown for $USER in sshd logs even if I got authenticated Message-ID: <bug-234793-227-zM4NIIc1Ug@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-234793-227@https.bugs.freebsd.org/bugzilla/>
index | next in thread | previous in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234793 Henry Hu <henry.hu.sh@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |henry.hu.sh@gmail.com --- Comment #23 from Henry Hu <henry.hu.sh@gmail.com> --- This bug was introduced in https://reviews.freebsd.org/rS339216. In this commit, a wrapper was added for login_getpwclass. The line in the dispatch table says: {MONITOR_REQ_GETPWCLASS, MON_AUTH, mm_answer_login_getpwclass}, Because the flag is MON_AUTH, which includes MON_AUTHDECIDE, which means #define MON_AUTHDECIDE 0x0008 /* Decides Authentication */ So the result of this wrapped call is recorded through auth_log() at line 339 of monitor.c: https://svnweb.freebsd.org/base/head/crypto/openssh/monitor.c?view=markup#l343 mm_answer_login_getpwclass only retrieves some information from logincap, so it does not decide the authentication result, and it always returns 0. Thus, I think that the flag is incorrectly set. I think that the correct value should be MON_ISAUTH. -- You are receiving this mail because: You are the assignee for the bug.help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-234793-227-zM4NIIc1Ug>