Date: Tue, 6 Apr 2004 14:26:24 -0400 From: Mathew Kanner <mat@cnd.mcgill.ca> To: Doug White <dwhite@gumbysoft.com> Cc: Mathew Kanner <mat@cnd.mcgill.ca> Subject: Re: dev/sound/pcm/sound.h shadows INTR_MPSAFE declaration Message-ID: <20040406182624.GA79561@cnd.mcgill.ca> In-Reply-To: <20040406103912.R89264@carver.gumbysoft.com> References: <C192C8912E798F4399668791C8965190674FD6@mx.hhp.local> <20040406103912.R89264@carver.gumbysoft.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Apr 06, Doug White wrote: > On Tue, 6 Apr 2004, Yuriy Tsibizov wrote: > > > > > Today I've noticied that my driver is marked as Giant-locked: > > > > > > Is it actually MPSAFE? If so, feel free to mark it as such, > > > although pcm > > > isn't fully locked yet, so we take no responsibility for any damage > > > caused :) > > > > Some sound drivers in -CURRENT allocate interrupts with INTR_MPSAFE. > > The problem is that after including dev/sound/pcm/sound.h INTR_MPSAFE no longer equals to 512, but it is set to 0. And if sound driver interrupt was allocated as INTR_TYPE_AV|INTR_MPSAFE it will be marked only as INTR_TYPE_TTY. > > Ever think that might be intentional? :) I'd poke -multimedia to get the > sound driver folks, though. Hello All, I've noticed the same things. I think I tried once to allow for it to MPSAFE (when I was mucking around with the emu10k1 driver). I think if you poke further, the sound drivers aren't always locked properly and hence not MPSAFE. I won't have time to dig into this until friday. --Mat -- It's impossible to awaken a man who is pretending to be asleep. - Navajo saying
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040406182624.GA79561>