Date: Mon, 29 Jun 2015 23:16:16 -0400 From: Julio Merino <jmmv@FreeBSD.org> To: Garrett Cooper <yaneurabeya@gmail.com> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r284912 - head/usr.bin/units Message-ID: <6A6AEA93-6E0B-4CB2-93B0-059235190A4C@FreeBSD.org> In-Reply-To: <AA256201-43F0-4889-A02C-96B8118E07FC@gmail.com> References: <201506281643.t5SGh7D9009454@svn.freebsd.org> <AA256201-43F0-4889-A02C-96B8118E07FC@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jun 28, 2015, at 15:05 , Garrett Cooper <yaneurabeya@gmail.com> = wrote: >=20 >=20 >> On Jun 28, 2015, at 09:43, Julio Merino <jmmv@FreeBSD.org> wrote: >>=20 >> Author: jmmv >> Date: Sun Jun 28 16:43:07 2015 >> New Revision: 284912 >> URL: https://svnweb.freebsd.org/changeset/base/284912 >>=20 >> Log: >> Only initialize libedit when necessary >>=20 >> The code path to support units conversions from the command line >> need not initialize neither libedit nor the history. Therefore, only = do >> that when in interactive mode. >>=20 >> This hides the issue reported in PR bin/201167 whereby running = commands >> of the form 'echo "$(units ft in)"' would corrupt the terminal. The = real >> issue causing the corruption most likely still remains somewhere. >>=20 >> PR: bin/201167 >> Differential Revision: D2935 >> Reviewed by: eadler >=20 > Jenkins has been so messed up recently with timeouts and the like that = it's hard to tell where things went south.. >=20 > Can you please add your TERM and locale variables to the PR? I suspect = that it might be a related issue.. Details added, but I don=E2=80=99t think they make a difference. Could = reproduce the above under multiple combinations.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6A6AEA93-6E0B-4CB2-93B0-059235190A4C>