Date: Fri, 30 Jan 2015 18:45:56 -0500 From: John Baldwin <jhb@freebsd.org> To: Elizabeth Myers <elizabeth@interlinked.me> Cc: freebsd-current@freebsd.org Subject: Re: Questions on adding backlight support for the i915 driver Message-ID: <3595567.zVLW9tlg0N@ralph.baldwin.cx> In-Reply-To: <54CC0999.90500@interlinked.me> References: <54C883E7.4000300@interlinked.me> <54CBA0A4.30708@FreeBSD.org> <54CC0999.90500@interlinked.me>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, January 30, 2015 04:45:45 PM Elizabeth Myers wrote: > On 01/30/15 09:17, John Baldwin wrote: > > Humm. If the code is going to live in the drm driver, then I would > > start with hanging a sysctl off of the drm device itself. (Each new-bus > > device_t has a sysctl ctx you can get to hang new nodes off of the > > device's node.) > > I'm wondering if that's the correct place for it to live. So far it's > the only real place it *can* live that makes logical sense imho, unless > anyone has better ideas. > > This is awesome. As for upower, it should probably be patched to know > about other types of brightness sysctls if/when this is implemented. For now I think hanging it off of the device_t is fine. It can be moved later if there is an urgent need. However, I suspect that tools like upower will need updating regardless of where it ends up living. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3595567.zVLW9tlg0N>