Date: Mon, 27 Apr 2026 11:36:38 -0700 From: "Simon J. Gerraty" <sjg@juniper.net> To: =?us-ascii?Q?=3D=3Futf-8=3FQ=3FDag-Erling=5FSm=3DC3=3DB8rgrav=3F=3D?= <des@freebsd.org> Cc: <src-committers@freebsd.org>, <dev-commits-src-all@freebsd.org>, <dev-commits-src-main@freebsd.org>, <sjg@juniper.net> Subject: Re: git: 566cc005812b - main - safe_set treat ':' and '#' differently Message-ID: <24831.1777314998@kaos.jnpr.net> In-Reply-To: <86bjf41chq.fsf@ltc.des.dev> References: <69e8f964.39869.24418b55@gitrepo.freebsd.org> <86jyts1xzr.fsf@ltc.des.dev> <15177.1777314263@kaos.jnpr.net> <86bjf41chq.fsf@ltc.des.dev>
index | next in thread | previous in thread | raw e-mail
Dag-Erling Smørgrav <des@freebsd.org> wrote: > > The goal here is to ensure a line like that will be ignored. > > That's beside the point, which is that your regex is incorrect. It will > treat e.g. `:foo` as a comment. Which is fine by me. That is not a syntax one commonly expects to see in rc.conf.d/* safe_eval is used it sitations where we are paranoid, normally only wanting to read *verified* input, but there are exceptions to every rule, and the goal of safe_set is to ensure nothing wicked gets eval'd. So I don't mind rejecting :foo=barhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?24831.1777314998>