Date: Wed, 7 Jan 2009 15:13:03 GMT From: Hans Petter Selasky <hselasky@FreeBSD.org> To: Perforce Change Reviews <perforce@FreeBSD.org> Subject: PERFORCE change 155759 for review Message-ID: <200901071513.n07FD3Do019127@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=155759 Change 155759 by hselasky@hselasky_laptop001 on 2009/01/07 15:12:24 Optimise: Remove extra flush calls. Affected files ... .. //depot/projects/usb/src/sys/dev/usb2/controller/ohci2.c#22 edit Differences ... ==== //depot/projects/usb/src/sys/dev/usb2/controller/ohci2.c#22 (text+ko) ==== @@ -1558,13 +1558,12 @@ } ed->ed_flags = htole32(ed_flags); - usb2_pc_cpu_flush(ed->page_cache); - td = xfer->td_transfer_first; ed->ed_headp = td->td_self; if (xfer->udev->pwr_save.suspended == 0) { + /* the append function will flush the endpoint descriptor */ OHCI_APPEND_QH(ed, *ed_last); if (methods == &ohci_device_bulk_methods) { @@ -2009,13 +2008,12 @@ } ed->ed_flags = htole32(ed_flags); - usb2_pc_cpu_flush(ed->page_cache); - td = xfer->td_transfer_first; ed->ed_headp = td->itd_self; /* isochronous transfers are not affected by suspend / resume */ + /* the append function will flush the endpoint descriptor */ OHCI_APPEND_QH(ed, sc->sc_isoc_p_last); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200901071513.n07FD3Do019127>