Date: Mon, 24 Jun 2002 11:23:00 -0400 From: Mikhail Teterin <mi+mx@aldan.algebra.com> To: Poul-Henning Kamp <phk@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libmd md5c.c Message-ID: <200206241123.00587.mi%2Bmx@aldan.algebra.com> In-Reply-To: <200206221254.g5MCsBt36492@freefall.freebsd.org> References: <200206221254.g5MCsBt36492@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday 22 June 2002 08:54 am, Poul-Henning Kamp wrote: = phk 2002/06/22 05:54:11 PDT = = Modified files: = lib/libmd md5c.c = Log: = Improve the handling of Encode and Decode operations in MD5. = = Use memcpy for all little-endian architectures, sys/kern/md5c.c = indicates this should be safe for all currently supported LE archs. = = Change the Encode and Decode functions for other archs to use = le32toh() and htole32() functions instead of explicit byte = shuffling. = = On sparc64 this gives md5(1) about 8% speed increase. Great, but what about the rest of the mdXc.c? At least, md4c has a very similar Encode(). Also, how about adding an attempt to use mmap to the MDXFileChunk(3) -- while you are there :-) ? Getting rid of the buffer and calling MDXUpdate just once should be quite helpful too... Yours, -mi To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200206241123.00587.mi%2Bmx>