Date: Sat, 12 Jul 2014 23:06:33 +0200 From: Dimitry Andric <dim@freebsd.org> To: Ed Schouten <ed@80386.nl> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Pietro Cerutti <gahr@freebsd.org> Subject: Re: svn commit: r268491 - head/usr.bin/users Message-ID: <7E0B8EDA-7932-454B-BACC-FCA956CD012E@freebsd.org> In-Reply-To: <CAJOYFBDZiEpQ5e86%2BdBhRZobSjdf785bKBwh%2B3Eywhzn_iJJCQ@mail.gmail.com> References: <201407101215.s6ACF3v1055260@svn.freebsd.org> <CAJOYFBCQjjN7ep12zivnmFjfeeP1SeoYa963mQbMJr9DD%2BfUnw@mail.gmail.com> <20140710152353.GF1812@ptrcrt.ch> <CAJOYFBDZiEpQ5e86%2BdBhRZobSjdf785bKBwh%2B3Eywhzn_iJJCQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10 Jul 2014, at 17:29, Ed Schouten <ed@80386.nl> wrote: > On 10 July 2014 17:23, Pietro Cerutti <gahr@freebsd.org> wrote: >> It's because of the standard library. Examples: >> >> /usr/include/c++/v1/memory:1454:47: error: unused parameter '__a' >> [-Werror,-Wunused-parameter] >> static void construct(allocator_type& __a, _Tp* __p) >> >> /usr/include/c++/v1/__functional_base:85:12: error: cast from 'const >> volatile char *' to 'wchar_t *' increases required alignment from 1 to 4 >> [-Werror,-Wcast-align] >> return (_Tp*)&reinterpret_cast<const volatile char&>(__x); > > Then I would suggest that these specific warnings (-Wunused-parameter) > were to be disabled for C++ programs. The actual consumers should not > have to lower their WARNS, simply because the standard library is > broken. IMHO it is not broken at all, but for some reason we compile everything with -Wsystem-headers when WARNS=1 or higher. :-) -Dimitry
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7E0B8EDA-7932-454B-BACC-FCA956CD012E>