Date: Wed, 30 Jun 2010 20:44:15 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Tom Evans <tevans.uk@googlemail.com> Cc: freebsd-current <freebsd-current@freebsd.org> Subject: Re: Ports doesnt respect fetch environment settings Message-ID: <86pqz8mkcg.fsf@ds4.des.no> In-Reply-To: <AANLkTinxzijyXsAQIdf75cw-GeRH_Wd1E8zIYmU-Xlfd@mail.gmail.com> (Tom Evans's message of "Wed, 30 Jun 2010 14:47:55 %2B0100") References: <AANLkTinn5bPXDf-tRIlpGCp3iFgtYi20mzRSbqkBcj6b@mail.gmail.com> <20100621101046.GA76036@droso.net> <AANLkTilhgzVDFX9MGQTS_DzJt_5QtlaNF--nQss-5mzj@mail.gmail.com> <20100621130743.4df77343@ernst.jennejohn.org> <AANLkTikrXvx_3Y7nkceaKSYqLQemGrIBURt1-5pwl6qr@mail.gmail.com> <AANLkTinxzijyXsAQIdf75cw-GeRH_Wd1E8zIYmU-Xlfd@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Tom Evans <tevans.uk@googlemail.com> writes: > Sorry to bump this again. I've diluted this issue down to the core > points and raised as a pr - can someone take a look, see if my > solution is correct and commit if appropriate? Sorry, fell through the cracks. Your analysis is correct, but I'm not 100% sure about the patch. Can you verify that your change does not introduce the possibility of an infinite loop in edge cases? I don't *think* it does, but like I said, I'm not 100% sure and I don't have time to reacquaint myself with the code right now, especially not that particularly nasty part of it :) DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86pqz8mkcg.fsf>