Date: Fri, 26 May 2000 15:13:42 +0900 From: Kenji Yabuuchi <yab@astem.or.jp> To: Gregory Bond <gnb@itga.com.au> Cc: freebsd-bugs@FreeBSD.ORG Subject: Re: kern/18526: mx does not receive ethernet broadcast packet Message-ID: <200005260613.PAA29126@astemfs.astem.or.jp> In-Reply-To: Your message of "Fri, 26 May 2000 15:52:35 %2B1000." <200005260552.PAA20510@lightning.itga.com.au>
next in thread | previous in thread | raw e-mail | index | archive | help
>>>>> On Fri, 26 May 2000 15:52:35 +1000, Gregory Bond <gnb@itga.com.au> said: >> + if (t->mx_did == MX_DEVICEID_987x5) >> + if (rev != MX_REVISION_98715AEC) >> + t++; >> + else if (rev >= MX_REVISION_98725) >> + t++; |> Either I'm dense or this is not right (or at the very least, wildly redundant). |> if (rev != a) t++; |> else if (rev >= b) t++; |> makes no sense when a & b are constant. Yes, you're right. This part should be: if (rev != MX_REVISION_98715AEC || rev >= MX_REVISION_98725) t++; -- ASTEM RI yab@astem.or.jp To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200005260613.PAA29126>