Date: Mon, 5 Nov 2018 15:00:37 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Alex Richardson <arichardson@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r339636 - in head: . share/mk Message-ID: <9612d267-91dc-b1ee-7530-284376f08f08@FreeBSD.org> In-Reply-To: <201810230631.w9N6VPR4008554@repo.freebsd.org> References: <201810230631.w9N6VPR4008554@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hBqK5Vdxe07UnxEP7yEVJYemQEKdP1PPy Content-Type: multipart/mixed; boundary="eiYBUoqmRiQcvYiHd4IkzCmmkYhJJEZuZ"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Alex Richardson <arichardson@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <9612d267-91dc-b1ee-7530-284376f08f08@FreeBSD.org> Subject: Re: svn commit: r339636 - in head: . share/mk References: <201810230631.w9N6VPR4008554@repo.freebsd.org> In-Reply-To: <201810230631.w9N6VPR4008554@repo.freebsd.org> --eiYBUoqmRiQcvYiHd4IkzCmmkYhJJEZuZ Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 10/22/2018 11:31 PM, Alex Richardson wrote: > Author: arichardson > Date: Tue Oct 23 06:31:25 2018 > New Revision: 339636 > URL: https://svnweb.freebsd.org/changeset/base/339636 >=20 > Log: > Only compute the X_COMPILER_*/X_LINKER_* variables when needed > =20 > When building CheriBSD we have to set XLD/XCC/XCFLAGS on the command = line. > This triggers the $XCC !=3D $CC case in bsd.compiler.mk (and the same= for LD > in bsd.linker.mk) which causes it to call ${XCC} --version and > ${XLD} --version (plus various awk+sed+echo calls) in every subdirect= ory. > For incremental builds and stages that only walk the source tree this= is > often the majority of the time spent in that directory. > =20 =2E.. > By only computing the value of the X_COMPILER_*/X_LINKER_* variables = if > _WANT_TOOLCHAIN_CROSS_VARS is set we can reduce the number of cc/ld c= alls > to once per build stage instead of once per recursive make. This sounds wrong. bsd.compiler.mk *already* handles that kind of thing by exporting its computations. Adding a second hack for a similar problem isn't the right solution. > =20 > With this change (and no changes to the sources) the `make includes` = stage > now takes 28 seconds at -j1 instead of 86 seconds. > =20 > Approved By: brooks (mentor) > Differential Revision: https://reviews.freebsd.org/D17046 --=20 Regards, Bryan Drewery --eiYBUoqmRiQcvYiHd4IkzCmmkYhJJEZuZ-- --hBqK5Vdxe07UnxEP7yEVJYemQEKdP1PPy Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEE+Rc8ssOq6npcih8JNddxu25Gl88FAlvgy5ZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY5 MTczQ0IyQzNBQUVBN0E1QzhBMUYwOTM1RDc3MUJCNkU0Njk3Q0YACgkQNddxu25G l89MOQf/S6gcHKeuiQl6tEJq1vLpA4oN+8HKOTWYXsQs26hCzQ0DVfHo4jbHS9R6 WWUDjULTrKLbZIvs4Y5ql3s6jRX/Okz14nvPPJPeMOL2s8MrrMmuTOuz4OQMLwAw TT+P7fWRC9VjHi47SO12DSgg7lm7XAcdlVar0fGJUwvhKQ8CImqjedMIZNItm+O6 6GnTLM/UvPtR4C6XKutn+MTVrgUh/sXJYUJ2g0RjSOp//FhGFH7f8Q1yIRj3DhxQ FVMze6SN7cNKJ2a6ncZZG3Fsb8HSQVOIQqmg9JwQSNvztrWXzcaFr66JX+/bvYKk rRGVCjoOnKKvmigimQsL0dJHnSKGlg== =dyED -----END PGP SIGNATURE----- --hBqK5Vdxe07UnxEP7yEVJYemQEKdP1PPy--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9612d267-91dc-b1ee-7530-284376f08f08>