Date: Sun, 13 Jan 2002 00:56:24 +0000 From: Ian Dowse <iedowse@maths.tcd.ie> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: Alfred Perlstein <bright@mu.org>, "Alan L. Cox" <alc@imimic.com>, FreeBSD-hackers@FreeBSD.ORG Subject: Re: Need review of NFS patch set for server .. missing/wrong vput() issues Message-ID: <200201130056.aa91209@salmon.maths.tcd.ie> In-Reply-To: Your message of "Sun, 13 Jan 2002 00:43:40 GMT." <200201130043.aa90380@salmon.maths.tcd.ie>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <200201130043.aa90380@salmon.maths.tcd.ie>, Ian Dowse writes: >I don't think this is necessary, because the cleanup code at the >end of nfsrv_mknod() catches any cases where nd.ni_vp was not >released earlier. It would be harmless to add it though. Oops, I missed a 'return (0);' when reading the code. You're quite correct here; the first part of the patch looks correct, and could certainly cause vput's to be forgotten. I'll try to reproduce this now. It's just the vp == dvp stuff that is ok as it is. Ian To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200201130056.aa91209>