Date: Sat, 31 Aug 2002 02:25:23 -0700 From: Jordan K Hubbard <jkh@queasyweasel.com> To: Kris Kennaway <kris@obsecurity.org> Cc: Mikhail Teterin <mi+mx@aldan.algebra.com>, arch@FreeBSD.org, jkh@FreeBSD.org Subject: Re: pkg-routines ignore the recorded md5 checksums Message-ID: <936EE14E-BCC3-11D6-A85D-0003938C7B7E@queasyweasel.com> In-Reply-To: <20020831073845.GA74568@xor.obsecurity.org>
index | next in thread | previous in thread | raw e-mail
Works for me... Go for it.
On Saturday, August 31, 2002, at 12:38 AM, Kris Kennaway wrote:
> On Sat, Aug 31, 2002 at 12:26:51AM -0700, Jordan K Hubbard wrote:
>> Hysterical Raisins. We didn't even think of adding md5 checksums
>> until
>> about a year or so after the pkg_install tools were done, and there
>> was
>> concern at that point that adding another @foo directive would create
>> a
>> set of "new packages" which didn't work with the older package tools.
>> So it was decided to simply make them a special type of comment, which
>> the previous package tools would simply ignore. In hindsight, of
>> course...
>
> Perhaps we should change plist.c to make unrecognised commands
> non-fatal, so we can have more flexibility about extending the
> commandset in future.
>
> Kris
>
> Untested patch:
>
> Index: usr.sbin/pkg_install/lib/plist.c
> ===================================================================
> RCS file: /usr2/ncvs/src/usr.sbin/pkg_install/lib/plist.c,v
> retrieving revision 1.29.2.9
> diff -u -r1.29.2.9 plist.c
> --- usr.sbin/pkg_install/lib/plist.c 20 Aug 2002 06:35:08
> -0000 1.29.2.9
> +++ usr.sbin/pkg_install/lib/plist.c 31 Aug 2002 07:37:51 -0000
> @@ -276,7 +276,7 @@
> cmd = plist_cmd(pline + 1, &cp);
> if (cmd == FAIL) {
> cleanup(0);
> - errx(2, "%s: bad command '%s'", __func__, pline);
> + warnx("%s: unknown command '%s' (package tools out of date?)",
> __func__, pline);
> }
> if (*cp == '\0') {
> cp = NULL;
> <mime-attachment>
--
Jordan K. Hubbard
Engineering Manager, BSD technology group
Apple Computer
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?936EE14E-BCC3-11D6-A85D-0003938C7B7E>