Date: Thu, 20 Mar 2025 02:53:16 GMT From: Mark Johnston <markj@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 48d6b52add36 - main - devfs: Return early from sysctl_devname() if no input is given Message-ID: <202503200253.52K2rGIF046499@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=48d6b52add36cc09e7fb1fbec44ab66c0742f320 commit 48d6b52add36cc09e7fb1fbec44ab66c0742f320 Author: Mark Johnston <markj@FreeBSD.org> AuthorDate: 2025-03-20 01:34:10 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2025-03-20 01:34:10 +0000 devfs: Return early from sysctl_devname() if no input is given Otherwise we end up searching for a device using an uninitialized key, tripping up KMSAN. MFC after: 2 weeks --- sys/fs/devfs/devfs_devs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/fs/devfs/devfs_devs.c b/sys/fs/devfs/devfs_devs.c index db879efe803a..c6dcd4fc7646 100644 --- a/sys/fs/devfs/devfs_devs.c +++ b/sys/fs/devfs/devfs_devs.c @@ -86,6 +86,9 @@ sysctl_devname(SYSCTL_HANDLER_ARGS) struct cdev_priv *cdp; struct cdev *dev; + if (req->newptr == NULL) + return (EINVAL); + #ifdef COMPAT_FREEBSD11 if (req->newlen == sizeof(ud_compat)) { error = SYSCTL_IN(req, &ud_compat, sizeof(ud_compat));
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202503200253.52K2rGIF046499>