Date: Fri, 29 Jul 2011 23:55:17 +0000 (UTC) From: Adrian Chadd <adrian@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/dev/ath if_ath_sysctl.c Message-ID: <201107292355.p6TNtaEM023556@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
adrian 2011-07-29 23:55:17 UTC
FreeBSD src repository
Modified files:
sys/dev/ath if_ath_sysctl.c
Log:
SVN rev 224502 on 2011-07-29 23:55:17Z by adrian
Reset the NIC if ANI is enabled or disabled.
Although this may not be what the original sysctl was designed to do,
it feels a bit more "expected".
Before, if ANI is disabled, the initial ANI parameters are still written
to the hardware, even if they're not enabled. "ANI enabled" would then
adjust the noise immunity parameters dynamically. Disabling ANI would
simply leave the existing noise immunity parameters where they are,
and disable the dynamic part.
The problem is that disabling ANI doesn't leave the hardware in
a consistent, predictable state - so asking a user to disable ANI
wouldn't actually reset the NIC to a consistent set of PHY signal
detection parameters, resulting in an unpredictable/unreliable outcome.
This makes it difficult to get reliable debugging information from
the user.
Approved by: re (kib)
Revision Changes Path
1.7 +15 -1 src/sys/dev/ath/if_ath_sysctl.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201107292355.p6TNtaEM023556>