Date: Sat, 16 Aug 2003 18:43:00 +0200 From: Pawel Jakub Dawidek <nick@garage.freebsd.pl> To: Robert Watson <rwatson@FreeBSD.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 35655 for review Message-ID: <20030816164300.GS395@garage.freebsd.pl> In-Reply-To: <200308062120.h76LKi3d003275@repoman.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Wed, Aug 06, 2003 at 02:20:44PM -0700, Robert Watson wrote: +> - mode ~= cmask; +> + mode = mode &~ cmask; IMHO this is a style bug. This should be: mode = mode & ~cmask; On time, when I was tired, I've spend few minutes wondering why 'foo' after this operation isn't equal to 'foo - bar':) foo =- bar; -- Pawel Jakub Dawidek pawel@dawidek.net UNIX Systems Programmer/Administrator http://garage.freebsd.pl Am I Evil? Yes, I Am! http://cerber.sourceforge.net [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) iQCVAwUBPz5fFD/PhmMH/Mf1AQFIugP8DHWvRG0vWdFoQL2v5McFuxTZmvFgcxqo UmwdJvh/kQaAUXFyaXZmXSzjpRFkdl3EVSCVhhBmXS82kdjqM6nqotpdMes1K5E3 3BpZAchUhFb0xAzRsS7mSHlbftFIF7a+KKAZE8rpqmrD5kqREK9PxB4noQC8vc/9 /uEp4NZEVAw= =Fse2 -----END PGP SIGNATURE-----help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030816164300.GS395>