Date: Mon, 13 Sep 2004 01:40:23 GMT From: Dan Lukes <dan@obluda.cz> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/71618: [PATCH] cleanup of the usr.sbin/timed code Message-ID: <200409130140.i8D1eNfl062228@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/71618; it has been noted by GNATS. From: Dan Lukes <dan@obluda.cz> To: Giorgos Keramidas <keramida@freebsd.org> Cc: bug-followup@freebsd.org Subject: Re: bin/71618: [PATCH] cleanup of the usr.sbin/timed code Date: Mon, 13 Sep 2004 03:37:11 +0200 (CEST) On Sun, 12 Sep 2004, Giorgos Keramidas wrote: >> - fprintf(fd, "%s %d %-6u (%ld,%ld) %-15s %s\n", >> + fprintf(fd, "%s %d %-6u (%d,%d) %-15s %s\n", > > There's no guarantee that an int32_t value will be defined with an `int'. > This might result in unexpected truncation of the printed value. A better True. In the fact, I miss the existence of 'j' modifier and intmax_t type. > of work, can you try the following (and see if you can come up with fixes > for the warnings this shows)? > > # cd /usr/src/usr.sbin/timed/ > # make NO_WERROR=1 WARNS?=3 I'm compiling with -Wall -O3. It seems to be more than any WARNS=X If there are some warning not corrected by attached patches, then it mean I'm don't know how the good way to correct it. > Thank you for your work so far :-) I have a lot of spare time now only ... ;-) Dan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200409130140.i8D1eNfl062228>