Date: Mon, 16 Jan 2012 02:13:39 +0800 From: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org> To: Yar <yarodin@gmail.com> Cc: cvs-ports@FreeBSD.org, poyopoyo@puripuri.plala.or.jp, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/archivers/unrar Makefile Message-ID: <20120115181339.GC45406@bonjour.sunpoet.net> In-Reply-To: <147869552.20120115123504@gmail.com> References: <201201080930.q089UX6D091198@repoman.freebsd.org> <8662gfjd02.wl%poyopoyo@puripuri.plala.or.jp> <147869552.20120115123504@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jan 15, 2012 at 12:35:04PM +0600, Yar wrote:
> Hello Poyopoyo,
>
> Saturday, January 14, 2012, 7:20:45, you wrote:
>
> > At Sun, 8 Jan 2012 09:30:33 +0000 (UTC),
> > Sunpoet Po-Chuan Hsieh wrote:
> >> @@ -24,6 +24,9 @@ MAKEFILE= makefile.unix
> >> PLIST_FILES= bin/unrar
> >> PORTDOCS= license.txt readme.txt
> >>
> >> +post-patch:
> >> + @${REINPLACE_CMD} -e '/^CXX/ s|^|#|' ${WRKSRC}/${MAKEFILE}
> >> +
> >> do-install:
> >> ${INSTALL_PROGRAM} ${WRKSRC}/unrar ${PREFIX}/bin
> >> .if !defined(NOPORTDOCS)
>
> > Hi,
> > Commenting CXX* out after patch phase breaks unrar-iconv since it
> > requires CXXFLAGS to be set in makefile.unix.
>
> ===>> Building for unrar-iconv-4.10,5
> > c++ -O2 -pipe -march=native -fno-strict-aliasing
> > -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DWITH_ICONV -DUNRAR -c rar.cpp
> > In file included from rar.hpp:5,
> > from rar.cpp:1:
> > os.hpp:197:19: error: iconv.h: No such file or directory
> > In file included from rar.hpp:76,
> > from rar.cpp:1:
> > global.hpp:19: error: 'iconv_t' does not name a type
> > global.hpp:20: error: 'iconv_t' does not name a type
> > gmake: *** [rar.o] Error 1
> > *** Error code 1
>
> > Here's a candidate:
> > - Comment CXX* out for only unrar not for unrar-iconv.
> I vote for it! \if !defined(USE_ICONV) at unrar Makefile\.
> It's more accuracy at my point of view.
>
> > - in unrar-iconv do the same thing with files/patch-iconv.
> BUT :) I attached tiny patch for unrar-iconv/Makefile
> with dirty workaround.
>
>
>
> --
> Best regards,
> Yar mailto:yarodin@gmail.com
Hi,
I have a suggestion for this build failure.
The patch for makefile.unix in unrar-iconv/files/patch-iconv can be replaced
by the following lines in unrar-iconv/Makefile.
CXXFLAGS+= -DWITH_ICONV -I${LOCALBASE}/include
LDFLAGS+= -L${LOCALBASE}/lib -liconv
Then, we can remove makefile.unix patch from unrar-iconv/files/patch-iconv.
If you agree with this change, I'll commit it ASAP.
Thanks.
Regards,
sunpoet
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120115181339.GC45406>