Date: Sun, 28 Feb 2010 16:25:49 +0000 (UTC) From: Konstantin Belousov <kib@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/net if_tap.c if_tun.c Message-ID: <201002281626.o1SGQBeS067127@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
kib 2010-02-28 16:25:49 UTC FreeBSD src repository Modified files: sys/net if_tap.c if_tun.c Log: SVN rev 204464 on 2010-02-28 16:25:49Z by kib In both if_tun and if_tap: Do not do additional dev_ref() on the newly created interface in the if_clone create method [1]. This reference is not needed and never removed, causing struct cdevpriv leakage. Remove the setting of SI_CHEAPCLONE flag as well, since it is unused. For dev_clone handlers, create cdevs with the call make_dev_credf(MAKEDEV_REF) instead of calling make_dev() and then dev_ref(), to avoid a race. Call drain_dev_clone_events() at the module unload time after dev_clone handler is deinstalled. Submitted by: Mikolaj Golub <to.my.trociny gmail com> [1] MFC after: 1 week Revision Changes Path 1.82 +3 -10 src/sys/net/if_tap.c 1.185 +2 -9 src/sys/net/if_tun.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201002281626.o1SGQBeS067127>