Date: Tue, 29 Dec 1998 23:48:24 +0100 From: Gary Jennejohn <garyj@peedub.muc.de> To: Poul-Henning Kamp <phk@FreeBSD.ORG> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin Makefile src/sys/net if_sppp.h if_spppsubr.c src/usr.sbin/spppcontrol Makefile spppcontrol.8 spppcontrol.c Message-ID: <199812292248.XAA70186@peedub.muc.de> In-Reply-To: Your message of "Sun, 27 Dec 1998 13:30:50 PST." <199812272130.NAA21915@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Poul-Henning Kamp writes:
>phk 1998/12/27 13:30:50 PST
>
> Modified files:
> usr.sbin Makefile
> sys/net if_sppp.h if_spppsubr.c
> Added files:
> usr.sbin/spppcontrol Makefile spppcontrol.8 spppcontrol.c
> Log:
> Update sppp support to i4b level. This includes the new spppcontrol
> program to set PPP options like authentication with.
>
what about this code from sppp_ipcp_RCR() in the i4b source ? This actually
_uses_ gotmyaddr which appears in a few places in the committted code.
I added this because some ISPs actually send the user's IP address a
little early. Note that there are some other changes required to set the
IPCP_MYADDR_DYN flag. Jo"rg left this code fragment out because he didn't
understand what it was doing and I had a short e-mail discussion about it
with him but he never committed it.
if (!(sp->ipcp.flags & IPCP_MYADDR_SEEN) &&
(sp->ipcp.flags & IPCP_MYADDR_DYN)) {
/*
* hopefully this is our address !!
*/
if (debug)
addlog("[wantmyaddr %s] ",
sppp_dotted_quad(desiredaddr));
/*
* When doing dynamic address assignment,
* we accept his offer. Otherwise, we
* ignore it and thus continue to negotiate
* our already existing value.
*/
sppp_set_ip_addr(sp, desiredaddr);
if (debug)
addlog("[agree] ");
sp->ipcp.flags |= IPCP_MYADDR_SEEN;
gotmyaddr++;
continue;
} else {
I can commit this if there are no disagreements.
---
Gary Jennejohn
Home - garyj@muc.de
Work - garyj@fkr.dec.com
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199812292248.XAA70186>