Date: Thu, 7 Oct 2010 20:24:36 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Mikolaj Golub <to.my.trociny@gmail.com> Cc: freebsd-fs@freebsd.org Subject: Re: hastd: assertion (res->hr_event != NULL) fails in secondary on split-brain Message-ID: <20101007182436.GB1733@garage.freebsd.pl> In-Reply-To: <20101005074736.GM7322@garage.freebsd.pl> References: <86hbh44wgl.fsf@kopusha.home.net> <86aamw4l42.fsf@kopusha.home.net> <20101004213647.GK7322@garage.freebsd.pl> <86tyl1m85y.fsf@zhuzha.ua1> <20101005074736.GM7322@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
--gatW/ieO32f1wygP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 05, 2010 at 09:47:36AM +0200, Pawel Jakub Dawidek wrote: > On Tue, Oct 05, 2010 at 10:05:13AM +0300, Mikolaj Golub wrote: > >=20 > > On Mon, 4 Oct 2010 23:36:47 +0200 Pawel Jakub Dawidek wrote: > >=20 > > PJD> I see three problems:) > >=20 > > PJD> 1. In child_kill() you interpret status value always, even if it = is > > PJD> invalid due to earlier errors. > > PJD> 2. While copying the code you changed style. Don't you like style= (9)?:) > >=20 > > Me like :-). But it looks like my emacs don't. Need to teach it somehow= ... > >=20 > > PJD> 3. The patch doesn't fix the root cause of the problem. > >=20 > > Thank you for your comments. >=20 > The hang you reported is still not fixed, but I'm working on it. Could you verify if the primary/secondary loop doesn't cause hangs anymore with most recent hast? --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --gatW/ieO32f1wygP Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkyuEGQACgkQForvXbEpPzQa1ACgkY4v73X1hvxGw3xjtgpJReNO /MEAoJw6YR8bZgJvUT5KfFwpqbWGnWHx =0n0/ -----END PGP SIGNATURE----- --gatW/ieO32f1wygP--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101007182436.GB1733>