Date: Wed, 15 Aug 2018 18:41:28 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 230655] vlan(4) holds non-sleepable locks around driver ioctls Message-ID: <bug-230655-227@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D230655 Bug ID: 230655 Summary: vlan(4) holds non-sleepable locks around driver ioctls Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: np@FreeBSD.org CC: mmacy@FreeBSD.org, shurd@FreeBSD.org There was recent work in the stack to not hold non-sleepable locks around NIC driver ioctls. It seems that vlan(4) still does. begin_synchronized_op with the following non-sleepable locks held: exclusive rm vlan (vlan) r =3D 0 (0xfffff8000459e388) locked @ /root/ws/head/sys/net/if_vlan.c:1917 shared rm vlan_rm (vlan_rm) r =3D 0 (0xffffffff827e9480) locked @ /root/ws/head/sys/net/if_vlan.c:1914 stack backtrace: #0 0xffffffff81238331 at witness_debugger+0xf1 #1 0xffffffff812398a8 at witness_warn+0x3b8 #2 0xffffffff8326296c at begin_synchronized_op+0x6c #3 0xffffffff83275b72 at cxgbe_ioctl+0x382 #4 0xffffffff8132e24a at if_addmulti+0x38a #5 0xffffffff8134ebf4 at vlan_setmulti+0x384 #6 0xffffffff8134dbc7 at vlan_ioctl+0x797 #7 0xffffffff8132e24a at if_addmulti+0x38a #8 0xffffffff814181c8 at in_getmulti+0x178 #9 0xffffffff81417ee8 at in_joingroup_locked+0xb8 #10 0xffffffff81417e0a at in_joingroup+0x4a #11 0xffffffff8140f326 at in_aifaddr_ioctl+0xe46 #12 0xffffffff8140d6f8 at in_control+0x228 #13 0xffffffff8132abdd at ifioctl+0x7fd #14 0xffffffff8124e4ce at soo_ioctl+0x79e #15 0xffffffff8124053c at fo_ioctl+0x4c #16 0xffffffff81240291 at kern_ioctl+0x361 #17 0xffffffff8123fe6a at sys_ioctl+0x2ea --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-230655-227>