Date: Mon, 24 Mar 2003 10:06:04 -0600 From: "Jacques A. Vidrine" <nectar@FreeBSD.org> To: Martin Blapp <mbr@FreeBSD.org> Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/isc-dhcp/client dhclient.c Message-ID: <20030324160604.GB1911@madman.celabo.org> In-Reply-To: <200303232329.h2NNTaI5089971@repoman.freebsd.org> References: <200303232329.h2NNTaI5089971@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 23, 2003 at 03:29:36PM -0800, Martin Blapp wrote: > mbr 2003/03/23 15:29:36 PST > > FreeBSD src repository > > Modified files: > contrib/isc-dhcp/client dhclient.c > Log: > We don't have cat(1) and kill(1) on the miniroot disks. > > This fix will be committed to the ISC repo later, but for now > take this file out of the vendor tree. > > Reviewed by: phk > Approved by: murray Are you sure that all values of pid_t can be represented in a signed int? + pid_t oldpid; ! e = fscanf(pidfd, "%d", &oldpid); I'd probably opt to do the fscanf with an unsigned long, and then cast the value to (pid_t). *shrug* Cheers, -- Jacques A. Vidrine <nectar@celabo.org> http://www.celabo.org/ NTT/Verio SME . FreeBSD UNIX . Heimdal Kerberos jvidrine@verio.net . nectar@FreeBSD.org . nectar@kth.se To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030324160604.GB1911>