Date: Thu, 18 Oct 2012 00:26:23 +0200 From: Guido Falsi <mad@madpilot.net> To: Andriy Gapon <avg@FreeBSD.org> Cc: Martin Matuska <mm@FreeBSD.org>, "current@FreeBSD.org" <current@FreeBSD.org> Subject: Re: Regression with ZFS on recent current Message-ID: <507F308F.90203@madpilot.net> In-Reply-To: <507F26F7.8090302@FreeBSD.org> References: <507EE9C1.7060800@madpilot.net> <507F1D9E.3010803@FreeBSD.org> <507F26F7.8090302@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/17/12 23:45, Andriy Gapon wrote: > on 18/10/2012 00:05 Andriy Gapon said the following: >> on 17/10/2012 20:24 Guido Falsi said the following: >>> Hi! >>> >>> While testing portshaker I found a regression in latest current. >>> >>> portshaker depends on ZFS(when enabling ZFS support) remounting >>> filesystems on the fly when changing the mountpoint property. This is >>> working as expected on 9.x while on 10-current is not working. Problem >>> has appeared sometime before October 3rd. >> >> Can you clarify what you mean but this date? >> That the problem didn't exist in head until recently? Can you name a date when >> the problem didn't exists in head then? Sorry, I was not clear. I was using -current from October 3rd up to this morning, when I noticed this problem. I tried updating to the latest sources to see if this was already solved by any of the recent commits to zfs. I can't pin down a date when -current was working right away. > > Oh, hmm, not sure if it is a bug that we imported from upstream or a porting > mistake. Before r238391 do_prefix variable in zfs_prop_set (in > cddl/contrib/opensolaris/lib/libzfs/common/libzfs_dataset.c) was always initialized. > Now it is either explicitly set to B_FALSE or left alone uninitialized. > > http://svnweb.freebsd.org/base/head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_dataset.c?r1=237119&r2=238391&pathrev=238391 > I can try reverting this diff and see if it solves the problem. Thanks for pointing out this commit. I'll report back as soon as I have tested this. -- Guido Falsi <mad@madpilot.net>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?507F308F.90203>