Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 3 Jul 2018 07:57:00 -0700
From:      John Baldwin <jhb@FreeBSD.org>
To:        Ruslan Bukin <br@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r335888 - in head: contrib/blacklist/bin lib/libpjdlog sbin/hastd
Message-ID:  <980f862d-02d0-a1ce-cf4c-1d39021013fb@FreeBSD.org>
In-Reply-To: <201807031353.w63DrsAa079940@repo.freebsd.org>
References:  <201807031353.w63DrsAa079940@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 7/3/18 6:53 AM, Ruslan Bukin wrote:
> Author: br
> Date: Tue Jul  3 13:53:54 2018
> New Revision: 335888
> URL: https://svnweb.freebsd.org/changeset/base/335888
> 
> Log:
>   o Ensure va_list is declared by including stdarg.h.
>   o Also move printf.h to go after it since it does require declaration
>     of va_list.
>   
>   This fixes build with latest RISC-V GNU Toolchain with GCC 8.1

Normal style(9) is to sort headers.  Also, <printf.h> includes <stdio.h> already
so should already have va_list defined.  I think there is some other build problem
you are running into with GCC 8.1.  Did you ensure you stripped all of the
'include-fixed' headers when you updated riscv64-gcc?  This seems to be an issue
of busted headers in the compiler and these changes should probably be reverted.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?980f862d-02d0-a1ce-cf4c-1d39021013fb>