Date: Fri, 14 Jun 2013 00:07:55 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: dchagin@freebsd.org, Michal Sviba <michal@sviba.cz>, freebsd-usb@freebsd.org, freebsd-amd64@freebsd.org Subject: Re: amd64/179376: xhci ehci irq storm Message-ID: <20130613210755.GF91021@kib.kiev.ua> In-Reply-To: <201306131018.30778.jhb@freebsd.org> References: <201306110920.r5B9K1m4071258@freefall.freebsd.org> <51B7563D.20807@sviba.cz> <20130611174822.GR3047@kib.kiev.ua> <201306131018.30778.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Pgaa2uWPnPrfixyx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Thu, Jun 13, 2013 at 10:18:30AM -0400, John Baldwin wrote:
> On Tuesday, June 11, 2013 1:48:22 pm Konstantin Belousov wrote:
> > + count =3D pci_msi_count(self);
> > + if (count >=3D 1) {
> > + if (count > 1)
> > + count =3D 1;
>=20
> You can just drop the if and always do the assignment here, yes?
> (Minor nit I know, and the original patch is fine for testing)
The comparision is useless, I removed it in my repo, thank you.
I remember somebody complained that xhci(4) cannot attach on the
Macs with the diagnostic about missing PRT entry for routing the
legacy interrupt. As if Apple does not care about proper legacy
routing. Hopefully, use of MSI-X would help there too.
Here is it:
http://lists.freebsd.org/pipermail/freebsd-current/2013-February/039595.html
http://people.freebsd.org/~dchagin/macbookpro/dmesg.generic.HEAD.txt
--Pgaa2uWPnPrfixyx
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (FreeBSD)
iQIcBAEBAgAGBQJRujSqAAoJEJDCuSvBvK1BUfQQAI8RZZXjoz13fQ7axTYKP8/s
2ZyqgxTveAhvaKJi5JxF4YdA8wx0KmVK4hzqUS9EZuHyLr/xUtf5tHMEme6ZTE13
6inB6Etftw7Znf4vt/hvgoIs53V76nVxp3vLYvPPm7MwHogjkZdziJFRs8NLgmV8
2mwOXyJmcbvOvF9KtO0zUMXcPgttb/417vPM5KZQ302XRpuwz840/4M8CMFP9B1Y
LFucIVwsNiMG7B2GfMvqfJs9+gJsY9x/0iTNgFCw6YgoOWYv3xO8oueFgZM2KIwk
T52/zaJw7BeLt406ZEj6zjGGISYx6lgKOO/IYdN+VQhez2pXkwtk8nZzfKtt+Erc
UjM68iIimPAXJ2Wk1bpa2a4IZR30w65ri858XtRNFCUpc8CqMzPu7KefLpOpClF4
pI8SBayiUPBcu9YQ2RUjyBCTKBYE9LsxDFHXZ1zrtDr+uQhEgfhaq7eVv6WWC/nU
lwHZQGVCO9bLJqLxvWzzg/wM8/R0OySERr9I7n3LGOyg7S4vm4CcBii4K/1G0N8b
wK/aUug9x4M5j4deFAi++4otf3e2vWDCxqiBKO74tOPb/EFS6h71aTgkSxL7glhy
xueFpe9Ax1Rv3Hpp8TZDYfquzgWuWPEOxcXpWpWDbrPC9DLrPrlJQBp6Ag8I4lwe
NbGTiZ/cvwYpZE3jz2D5
=NE9R
-----END PGP SIGNATURE-----
--Pgaa2uWPnPrfixyx--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130613210755.GF91021>