Date: Mon, 22 Jan 2018 15:30:03 +0100 From: Emmanuel Vadot <manu@bidouilliste.com> To: "Poul-Henning Kamp" <phk@phk.freebsd.dk> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328257 - in head/sys: arm/broadcom/bcm2835 dts/arm modules Message-ID: <20180122153003.664e1613bbf70ab49c5c1541@bidouilliste.com> In-Reply-To: <88258.1516630050@critter.freebsd.dk> References: <201801220710.w0M7AUm9091853@repo.freebsd.org> <20180122135905.203e19ce94510854777dff63@bidouilliste.com> <88070.1516628327@critter.freebsd.dk> <20180122145117.08173be547f5dd6fef296732@bidouilliste.com> <88258.1516630050@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 22 Jan 2018 14:07:30 +0000 "Poul-Henning Kamp" <phk@phk.freebsd.dk> wrote: > -------- > In message <20180122145117.08173be547f5dd6fef296732@bidouilliste.com>, Emmanuel > Vadot writes: > > > Using the same logic as before one could have a script starting some > >pwm stuff (or simply using /etc/sysctl.conf) > > Also this is not how DT is suppose to work, if the status == > >'disabled' no driver should attach. > > That doesn't make *any* UX sense. > > "disabled" indicates that it can be enabled, and there is absolutely > no reason to force users to reboot, when all that stands between > them and using their hardware is a random setting in a file. To be more clear, disabled mean that the node should not be used. In a industrial board you will always have every usable node enabled, in the SBC world where you have a way to plug daughter card and exchange them or even use the exposed pins directly there is no way to know what the user will do so every node not used by the SBC must be disabled. This is the overlay part of DT that is responsible to enable them > Explicitly kldload'ing a device-driver is as clear a "Enable it, please" > instruction as you can get from the user. But device driver != DT node > If you want to lock down this DT-device because some other > device/pin-mux/whatever makes its use impossible, then > status should not be "disabled" but "locked" or "impossible". Feel free to talk to the DT guys. > In particular it is *horrible* UX, that you kldload a device-driver > for hardware you know is there, and it just silently doesn't do > anything. At the very least it should give a diagnostic. > > Maybe something like: > > "For no good reason this device is disabled, google for > an hour, try to come up with a device tree overlay, reboot > to install it and see if you get lucky." > > :-) > > >> > Can you please revert this part ? > >> > >> Once I find out how to get similar behaviour, ie: kldload without > >> having to reboot to load a DT-overlay. > > > > Nobody is working on that right now (that I know of). > > Let me know when it works, and I'll remove my hack then. > > In the meantime, don't load bcm283x_pwm if you don't plan on > using the PWM on GPIO12 on your RPI[23]. > > -- > Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 > phk@FreeBSD.ORG | TCP/IP since RFC 956 > FreeBSD committer | BSD since 4.3-tahoe > Never attribute to malice what can adequately be explained by incompetence. -- Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180122153003.664e1613bbf70ab49c5c1541>