Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 4 Feb 2009 14:59:35 +0100
From:      Hans Petter Selasky <hselasky@c2i.net>
To:        Weongyo Jeong <weongyo@freebsd.org>
Cc:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   Re: PERFORCE change 157132 for review
Message-ID:  <200902041459.35445.hselasky@c2i.net>
In-Reply-To: <200902041242.n14CgXj2014958@repoman.freebsd.org>
References:  <200902041242.n14CgXj2014958@repoman.freebsd.org>

index | next in thread | previous in thread | raw e-mail

On Wednesday 04 February 2009, Weongyo Jeong wrote:
>         bzero(desc, sizeof(struct uath_tx_desc));
>         desc->msglen = htobe32(sizeof(struct uath_tx_desc));
> -       desc->msgid  = data_idx + 1;    /* don't care about endianness */
> +       desc->msgid  = (sc->sc_msgid++) + 1;    /* don't care about
> endianness */ desc->type   = htobe32(WDCMSG_FLUSH);
>         desc->txqid  = htobe32(0);
>         desc->connid = htobe32(0);

Why not allocate an mbuf to hold the "descriptor" data. Then you use the 
m_next field of the header mbuf to link with the "data" mbuf ? Then you only 
need one [mbuf] queue for TX ? You can look at if_ural2.c and if_rum2.c 
in /sys/dev/usb2/wlan .

--HPS


help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200902041459.35445.hselasky>