Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 18 Jan 2013 11:39:00 -0500
From:      John Baldwin <jhb@freebsd.org>
To:        freebsd-hackers@freebsd.org
Cc:        David Xu <davidxu@freebsd.org>
Subject:   Re: Fixing grep -D skip
Message-ID:  <201301181139.00910.jhb@freebsd.org>
In-Reply-To: <50F8B491.8090303@freebsd.org>
References:  <50F8B491.8090303@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday, January 17, 2013 9:33:53 pm David Xu wrote:
> I am trying to fix a bug in GNU grep, the bug is if you
> want to skip FIFO file, it will not work, for example:
> 
> grep -D skip aaa .
> 
> it will be stucked on a FIFO file.
> 
> Here is the patch:
> http://people.freebsd.org/~davidxu/patch/grep.c.diff2
> 
> Is it fine to be committed ?

I think the first part definitely looks fine.  My guess is the non-blocking 
change is als probably fine, but that should be run by the bsdgrep person at 
least.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201301181139.00910.jhb>