Date: Wed, 24 Sep 1997 06:39:41 +0000 (GMT) From: Terry Lambert <tlambert@primenet.com> To: kato@migmatite.eps.nagoya-u.ac.jp (KATO Takenori) Cc: jkh@time.cdrom.com, current@FreeBSD.ORG Subject: Re: Daily SNAPshots at current.freebsd.org shut down for now. Message-ID: <199709240639.XAA06060@usr07.primenet.com> In-Reply-To: <199709240358.MAA04770@gneiss.eps.nagoya-u.ac.jp> from "KATO Takenori" at Sep 24, 97 12:58:32 pm
next in thread | previous in thread | raw e-mail | index | archive | help
>
> > To undo the change in 1.49/1.41.2.1 of /sys/dev/vn/vn.c may hide the
> > panic. But, I think this is NOT real fix.
>
> I made patches for current and 2.2. They are better than undoing.
> Should they be committed?
Aiiiiiiiieeeeeee!!!!! The old version of the patch!!!!
This is in a for loop!
> ! if (vnodelocked)
{
> ! VOP_UNLOCK(vn->sc_vp);
vnodelocked = 0;
}
You can't leave it set to 1!!!!
You do the right thing in the -current patch:
[ ... ]
> ! if (vnodelocked) {
> ! VOP_UNLOCK(vn->sc_vp, 0, curproc);
> ! vnodelocked = 0;
> ! }
Terry Lambert
terry@lambert.org
---
Any opinions in this posting are my own and not those of my present
or previous employers.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199709240639.XAA06060>