Date: Mon, 7 Jun 2010 09:01:16 -0300 From: "Marcelo/Porks" <marcelorossi@gmail.com> To: Hans Petter Selasky <hselasky@c2i.net> Cc: Garrett Cooper <yanefbsd@gmail.com>, freebsd-current@freebsd.org Subject: Re: Fwd: umodem (4) recognize a CDC-ACM device Message-ID: <AANLkTim79iRBjLCxaQgleXAwwXexXto-oZQZg5VSUXMI@mail.gmail.com> In-Reply-To: <AANLkTildmORfr1xk2n1V2mEc4ZvDMxk9J1R1zmWiD5J9@mail.gmail.com> References: <AANLkTinuhcIfsFvowzbsDJWy-gqob40oNxUPN-OvXc2E@mail.gmail.com> <201006031757.03341.hselasky@c2i.net> <AANLkTikNX0D6u2kH8VkTklXsAgpl7aLZzD03gxZJhkdH@mail.gmail.com> <201006040928.09768.hselasky@c2i.net> <AANLkTildmORfr1xk2n1V2mEc4ZvDMxk9J1R1zmWiD5J9@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 4, 2010 at 12:32 PM, Marcelo/Porks <marcelorossi@gmail.com> wro=
te:
> On Fri, Jun 4, 2010 at 4:28 AM, Hans Petter Selasky <hselasky@c2i.net> wr=
ote:
>>> On Thu, Jun 3, 2010 at 12:57 PM, Hans Petter Selasky <hselasky@c2i.net>
>> wrote:
>>> > Should be like this: Note the structure is called "bulk_min":
>>> >
>>> > =A0 =A0 =A0 =A0static const uint16_t bulk_min[USB_SPEED_MAX] =3D {
>>> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0[USB_SPEED_LOW] =3D 8,
>>> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0[USB_SPEED_FULL] =3D 8,
>>> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0[USB_SPEED_HIGH] =3D 512,
>>> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0[USB_SPEED_VARIABLE] =3D 512,
>>> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0[USB_SPEED_SUPER] =3D 1024,
>>> > =A0 =A0 =A0 =A0};
>>> > --HPS
>> I think you also need to remove the check for LOW speed in the EHCI/OHCI=
/UHCI
>> controller drivers too. See usb/controller/{ehci.c,uhci.c,ohci.c}
>>
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0case UE_BULK:
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if (udev->speed !=3D USB_=
SPEED_LOW) {
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0ep->metho=
ds =3D &uhci_device_bulk_methods;
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0}
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0break;
>>
>> --HPS
>>
>
> Hia Hans! It seems to work now or at least it was recognized.
>
> I'll make more tests on Monday and post the results.
Hi all! Just to confirm, The patch works fine and I can use the device.
Bellow is the full patch that Hans sent to me in private. Thanks again, Han=
s.
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
Differences ...
=3D=3D=3D=3D //depot/projects/usb/src/sys/dev/usb/controller/ehci.c#53 (tex=
t+ko) =3D=3D=3D=3D
@@ -3792,9 +3792,7 @@
}
break;
case UE_BULK:
- if (udev->speed !=3D USB_SPEED_LOW) {
- ep->methods =3D &ehci_device_bulk_methods;
- }
+ ep->methods =3D &ehci_device_bulk_methods;
break;
default:
/* do nothing */
=3D=3D=3D=3D //depot/projects/usb/src/sys/dev/usb/controller/ohci.c#35 (tex=
t+ko) =3D=3D=3D=3D
@@ -2614,9 +2614,7 @@
}
break;
case UE_BULK:
- if (udev->speed !=3D USB_SPEED_LOW) {
- ep->methods =3D &ohci_device_bulk_methods;
- }
+ ep->methods =3D &ohci_device_bulk_methods;
break;
default:
/* do nothing */
=3D=3D=3D=3D //depot/projects/usb/src/sys/dev/usb/controller/uhci.c#32 (tex=
t+ko) =3D=3D=3D=3D
@@ -3068,9 +3068,7 @@
}
break;
case UE_BULK:
- if (udev->speed !=3D USB_SPEED_LOW) {
- ep->methods =3D &uhci_device_bulk_methods;
- }
+ ep->methods =3D &uhci_device_bulk_methods;
break;
default:
/* do nothing */
=3D=3D=3D=3D //depot/projects/usb/src/sys/dev/usb/usb_transfer.c#177 (text+=
ko) =3D=3D=3D=3D
@@ -3057,7 +3057,7 @@
};
static const uint16_t bulk_min[USB_SPEED_MAX] =3D {
- [USB_SPEED_LOW] =3D 0, /* not supported */
+ [USB_SPEED_LOW] =3D 8,
[USB_SPEED_FULL] =3D 8,
[USB_SPEED_HIGH] =3D 512,
[USB_SPEED_VARIABLE] =3D 512,
--=20
Marcelo Rossi
"This e-mail is provided "AS IS" with no warranties, and confers no rights.=
"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTim79iRBjLCxaQgleXAwwXexXto-oZQZg5VSUXMI>