Date: Sun, 13 Jan 2008 08:20:02 GMT From: Diomidis Spinellis <dds@aueb.gr> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/119614: regression tests for tr(1) Message-ID: <200801130820.m0D8K2gG090385@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/119614; it has been noted by GNATS.
From: Diomidis Spinellis <dds@aueb.gr>
To: Giorgos Keramidas <keramida@FreeBSD.ORG>
Cc: David Schultz <das@FreeBSD.ORG>, FreeBSD-gnats-submit@FreeBSD.ORG,
Diomidis Spinellis <dds@FreeBSD.ORG>
Subject: Re: bin/119614: regression tests for tr(1)
Date: Sun, 13 Jan 2008 09:36:41 +0200
Giorgos Keramidas wrote:
> On 2008-01-12 22:28, David Schultz <das@FreeBSD.ORG> wrote:
>> But I'd say commit whatever tests you have, so the next time we find a
>> bug, it will be a one-line change for someone to add a regression test
>> for it.
>
> Thanks. I'll wait a bit for Diomidis to see the PR too, in case he
> wants to add/change something. Then in 1-2 days I'll commit the current
> patch.
Great! As David commented the most important thing is to have a
regression test and a place where more tests can be added in the future.
So go ahead and commit it.
You might want to add tests for the [#*n] and the [=char=] notations.
Also, verify that your tests interact gracefully with Perl's
Test::Harness prove(1) command.
Diomidis Spinellis - http://www.spinellis.gr
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200801130820.m0D8K2gG090385>